WORK IN PROGRESS: test linting #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohanKarlbergg
force-pushed
the
linting
branch
2 times, most recently
from
8894d7e
to
d84d7e5
Compare
JohanKarlbergg
force-pushed
the
linting
branch
4 times, most recently
from
6ccb1c2
to
401dd93
Compare
OdoctorG
force-pushed
the
linting
branch
3 times, most recently
from
0ba6513
to
c64617b
Compare
JohanKarlbergg
force-pushed
the
linting
branch
2 times, most recently
from
225d1fe
to
e1e333e
Compare
JohanKarlbergg
commented
Jul 5, 2024
Comment on lines
22
to
24
| @pytest.fixture | ||
| def broker(): | ||
| def broker() -> Broker: | ||
| return Broker() |
There was a problem hiding this comment.
@pytest.fixture(name="broker")
def broker_fixture() -> Broker:
return Broker()
this way we can remove # pylint: disable=W0621
| .venv | ||
| __pycache__ | ||
| .* |
There was a problem hiding this comment.
I don't think we should ignore all dot files, lets remove ".*"
python/=0.1.8
Outdated
There was a problem hiding this comment.
Seems like it was added by mistake, remove it
fix: address pylint warnings fix: address pylint warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.